mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Borislav Petkov <bp@alien8.de>, "Tobin C. Harding" <me@tobin.cc>,
	LKML <linux-kernel@vger.kernel.org>,
	Nicholas Mc Guire <der.herr@hofr.at>,
	Vivek Goyal <vgoyal@redhat.com>,
	x86@kernel.org
Subject: Re: kexec, x86/purgatory: Cleanup the unholy mess
Date: Fri, 10 Mar 2017 15:56:13 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1703101554200.3681@nanos> (raw)
In-Reply-To: <1489156308.4706.0.camel@gmx.de>

On Fri, 10 Mar 2017, Mike Galbraith wrote:
> Stuffing the lot into .kexec-purgatory worked.

You beat me to it :)

And that's how that whole thing should have been done in the very beginning
instead of relying on uncomprehensible compile/link magics.

Thanks,

	tglx

> ---
>  arch/x86/purgatory/purgatory.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> --- a/arch/x86/purgatory/purgatory.c
> +++ b/arch/x86/purgatory/purgatory.c
> @@ -16,13 +16,13 @@
>  #include "sha256.h"
>  #include "../boot/string.h"
>  
> -unsigned long purgatory_backup_dest;
> -unsigned long purgatory_backup_src;
> -unsigned long purgatory_backup_sz;
> +unsigned long purgatory_backup_dest __section(.kexec-purgatory);
> +unsigned long purgatory_backup_src __section(.kexec-purgatory);
> +unsigned long purgatory_backup_sz __section(.kexec-purgatory);
>  
> -u8 purgatory_sha256_digest[SHA256_DIGEST_SIZE];
> +u8 purgatory_sha256_digest[SHA256_DIGEST_SIZE] __section(.kexec-purgatory);
>  
> -struct kexec_sha_region purgatory_sha_regions[KEXEC_SEGMENT_MAX];
> +struct kexec_sha_region purgatory_sha_regions[KEXEC_SEGMENT_MAX] __section(.kexec-purgatory);
>  
>  /*
>   * On x86, second kernel requries first 640K of memory to boot. Copy
> 

  reply	other threads:[~2017-03-10 14:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 12:17 Thomas Gleixner
2017-03-10 13:47 ` Mike Galbraith
2017-03-10 13:57   ` Thomas Gleixner
2017-03-10 14:24     ` Vivek Goyal
2017-03-10 14:58       ` Thomas Gleixner
2017-03-10 15:05         ` Vivek Goyal
2017-03-10 14:31     ` Mike Galbraith
2017-03-10 14:56       ` Thomas Gleixner [this message]
2017-03-10 14:58         ` Mike Galbraith
2017-03-10 15:31           ` Thomas Gleixner
2017-03-10 18:13             ` Mike Galbraith
2017-03-10 20:13 ` [tip:x86/urgent] kexec, x86/purgatory: Unbreak it and clean it up tip-bot for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1703101554200.3681@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@alien8.de \
    --cc=der.herr@hofr.at \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@tobin.cc \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®