From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933803AbdCKGuB (ORCPT ); Sat, 11 Mar 2017 01:50:01 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:11939 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933300AbdCKGtv (ORCPT ); Sat, 11 Mar 2017 01:49:51 -0500 X-IronPort-AV: E=Sophos;i="5.36,144,1486422000"; d="scan'208";a="216368386" Date: Sat, 11 Mar 2017 07:49:48 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: outreachy-kernel@googlegroups.com, sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 1/3] staging: sm750fb: function prototype argument should have an identifier name In-Reply-To: <20170311032410.8265-2-arushisinghal19971997@gmail.com> Message-ID: References: <20170311032410.8265-1-arushisinghal19971997@gmail.com> <20170311032410.8265-2-arushisinghal19971997@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Mar 2017, Arushi Singhal wrote: > function prototype arguments like 'struct vb_device_info *','unsigned > long' etc. should have an identifier name. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/sm750fb/ddk750_display.h | 2 +- > drivers/staging/sm750fb/ddk750_mode.h | 2 +- > drivers/staging/sm750fb/ddk750_power.h | 2 +- > drivers/staging/sm750fb/sm750.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h > index e2a3f84ca4c5..609bf742efff 100644 > --- a/drivers/staging/sm750fb/ddk750_display.h > +++ b/drivers/staging/sm750fb/ddk750_display.h > @@ -102,6 +102,6 @@ typedef enum _disp_output_t { > } > disp_output_t; > > -void ddk750_setLogicalDispOut(disp_output_t); > +void ddk750_setLogicalDispOut(disp_output_t output); > > #endif > diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h > index 2183e664cf4b..6d204b8b4a01 100644 > --- a/drivers/staging/sm750fb/ddk750_mode.h > +++ b/drivers/staging/sm750fb/ddk750_mode.h > @@ -34,6 +34,6 @@ typedef struct _mode_parameter_t { > } > mode_parameter_t; > > -int ddk750_setModeTiming(mode_parameter_t *, clock_type_t); > +int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock); There are typedefs here that you could get rid of in a future patch. > > #endif > diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h > index ec0b99d6a7ad..44c4fc587e96 100644 > --- a/drivers/staging/sm750fb/ddk750_power.h > +++ b/drivers/staging/sm750fb/ddk750_power.h > @@ -14,7 +14,7 @@ DPMS_t; > (peek32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \ > } > > -void ddk750_set_dpms(DPMS_t); > +void ddk750_set_dpms(DPMS_t state); > void sm750_set_power_mode(unsigned int powerMode); > void sm750_set_current_gate(unsigned int gate); > > diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h > index 306711ed55f9..5ea455dee949 100644 > --- a/drivers/staging/sm750fb/sm750.h > +++ b/drivers/staging/sm750fb/sm750.h > @@ -184,7 +184,7 @@ static inline unsigned long ps_to_hz(unsigned int psvalue) > } > > int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev); > -int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *); > +int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev); > void hw_sm750_initAccel(struct sm750_dev *); This prototype should be updated too. julia > int hw_sm750_deWait(void); > int hw_sm750le_deWait(void); > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170311032410.8265-2-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >