mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vince Weaver <vincent.weaver@maine.edu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tan Xiaojun <tanxiaojun@huawei.com>,
	jolsa@redhat.com, alexander.shishkin@linux.intel.com,
	eranian@google.com, mingo@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check
Date: Mon, 13 Mar 2017 14:35:11 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.1703131432371.12942@macbook-air> (raw)
In-Reply-To: <20170225095117.GU6500@twins.programming.kicks-ass.net>

On Sat, 25 Feb 2017, Peter Zijlstra wrote:

> On Sat, Feb 25, 2017 at 04:10:37PM +0800, Tan Xiaojun wrote:
> 
> > 2)If it is, where we will fix it more appropriate, perf_fuzzer(not set
> > 0 or 100) or kernel(limit 1 to 99), or maybe it is the bug of
> > hardware(too many hardware interruptions)?
> 
> I think the best would be if the fuzzer would not set 0,100, those are
> clearly 'unsafe' settings and you pretty much get to keep the pieces.
> 
> I would like to preserve these settings for people that 'know' what
> they're doing and are willing to take the risk, but clearly, when you
> take the guard-rails off, things can come apart.

sorry for the delay responding, these e-mails ended up in the spam folder
somehow.

I could add a new "avoid stupid things as root" flag for the perf_fuzzer.

Besides this issue, are there other known things to skip?

Generally running a fuzzer as root can be a bad idea which is why I don't 
test that use case very often.
I think there were other issues in the past, like certain ftrace 
combinations being known to lock the system.

Vince

  parent reply	other threads:[~2017-03-13 18:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23  6:04 [PATCH] perf/core: Fix to check perf_cpu_time_max_percent Tan Xiaojun
2017-02-24  9:15 ` [tip:perf/urgent] perf/core: Fix the perf_cpu_time_max_percent check tip-bot for Tan Xiaojun
2017-02-25  8:10   ` Tan Xiaojun
2017-02-25  9:51     ` Peter Zijlstra
2017-02-27  0:36       ` Tan Xiaojun
2017-03-13 18:35       ` Vince Weaver [this message]
2017-03-14  1:52         ` Tan Xiaojun
2017-04-15  7:58       ` [BUG arm64] OOPS when using /proc/kcore to disassemble the kernel symbols in "perf top" Tan Xiaojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1703131432371.12942@macbook-air \
    --to=vincent.weaver@maine.edu \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tanxiaojun@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®