From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753254AbdCMV1x (ORCPT ); Mon, 13 Mar 2017 17:27:53 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:34419 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbdCMV1p (ORCPT ); Mon, 13 Mar 2017 17:27:45 -0400 X-IronPort-AV: E=Sophos;i="5.36,161,1486422000"; d="scan'208";a="216604690" Date: Mon, 13 Mar 2017 22:27:16 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: w.d.hubbs@gmail.com, chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH v2 1/2] staging: speakup: Added blank line after function/struct/union/enum declarations In-Reply-To: <20170313204018.24601-2-arushisinghal19971997@gmail.com> Message-ID: References: <20170313204018.24601-1-arushisinghal19971997@gmail.com> <20170313204018.24601-2-arushisinghal19971997@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remember to use the imperative. "Add blank line...". You could just drop function/struct/union/enum. Just declarations is fine. On Tue, 14 Mar 2017, Arushi Singhal wrote: > This patch fixes the warnings reported by checkpatch.pl > for please use a blank line after function/struct/union/enum > declarations. Again, it does not say what you have done, and only focuses on the message you have fixed. julia > Signed-off-by: Arushi Singhal > --- > changes in v2 > - change the subject to make it more relevant. > > drivers/staging/speakup/main.c | 1 + > drivers/staging/speakup/serialio.c | 1 + > drivers/staging/speakup/speakup_dtlk.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index 6786cfab7460..4b750ec8cd59 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -108,6 +108,7 @@ enum { > CT_Window, > CT_Max > }; > + > #define read_all_mode CT_Max > > static struct tty_struct *tty; > diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c > index aade52ee15a0..d51e382cb835 100644 > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -21,6 +21,7 @@ static void start_serial_interrupt(int irq); > static const struct old_serial_port rs_table[] = { > SERIAL_PORT_DFNS > }; > + > static const struct old_serial_port *serstate; > static int timeouts; > > diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c > index eede2d82183a..c0b2208aa8a7 100644 > --- a/drivers/staging/speakup/speakup_dtlk.c > +++ b/drivers/staging/speakup/speakup_dtlk.c > @@ -43,6 +43,7 @@ static int port_forced; > static unsigned int synth_portlist[] = { > 0x25e, 0x29e, 0x2de, 0x31e, 0x35e, 0x39e, 0 > }; > + > static u_char synth_status; > > static struct var_t vars[] = { > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170313204018.24601-2-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >