From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750817AbdCNFrC (ORCPT ); Tue, 14 Mar 2017 01:47:02 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:42879 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbdCNFrB (ORCPT ); Tue, 14 Mar 2017 01:47:01 -0400 X-IronPort-AV: E=Sophos;i="5.36,162,1486422000"; d="scan'208";a="264428130" Date: Tue, 14 Mar 2017 06:46:52 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: w.d.hubbs@gmail.com, chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH v3 3/4] staging: sm750fb: Alignment should match open parenthesis In-Reply-To: <20170313204853.24675-4-arushisinghal19971997@gmail.com> Message-ID: References: <20170313204853.24675-1-arushisinghal19971997@gmail.com> <20170313204853.24675-4-arushisinghal19971997@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2017, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". I thought you were going to take another approach to improve this code? julia > > Signed-off-by: Arushi Singhal > --- > drivers/staging/sm750fb/ddk750_mode.c | 79 +++++++++++++++++------------------ > 1 file changed, 39 insertions(+), 40 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c > index 45af806c8d55..eea5aef2956f 100644 > --- a/drivers/staging/sm750fb/ddk750_mode.c > +++ b/drivers/staging/sm750fb/ddk750_mode.c > @@ -28,9 +28,9 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, > poke32(CRT_AUTO_CENTERING_TL, 0); > > poke32(CRT_AUTO_CENTERING_BR, > - (((y - 1) << CRT_AUTO_CENTERING_BR_BOTTOM_SHIFT) & > - CRT_AUTO_CENTERING_BR_BOTTOM_MASK) | > - ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK)); > + (((y - 1) << CRT_AUTO_CENTERING_BR_BOTTOM_SHIFT) & > + CRT_AUTO_CENTERING_BR_BOTTOM_MASK) | > + ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK)); > > /* > * Assume common fields in dispControl have been properly set before > @@ -72,8 +72,7 @@ static unsigned long displayControlAdjust_SM750LE(mode_parameter_t *pModeParam, > } > > /* only timing related registers will be programed */ > -static int programModeRegisters(mode_parameter_t *pModeParam, > - struct pll_value *pll) > +static int programModeRegisters(mode_parameter_t *pModeParam, struct pll_value *pll) > { > int ret = 0; > int cnt = 0; > @@ -83,32 +82,32 @@ static int programModeRegisters(mode_parameter_t *pModeParam, > /* programe secondary pixel clock */ > poke32(CRT_PLL_CTRL, sm750_format_pll_reg(pll)); > poke32(CRT_HORIZONTAL_TOTAL, > - (((pModeParam->horizontal_total - 1) << > - CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) & > - CRT_HORIZONTAL_TOTAL_TOTAL_MASK) | > - ((pModeParam->horizontal_display_end - 1) & > - CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK)); > + (((pModeParam->horizontal_total - 1) << > + CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) & > + CRT_HORIZONTAL_TOTAL_TOTAL_MASK) | > + ((pModeParam->horizontal_display_end - 1) & > + CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK)); > > poke32(CRT_HORIZONTAL_SYNC, > - ((pModeParam->horizontal_sync_width << > - CRT_HORIZONTAL_SYNC_WIDTH_SHIFT) & > - CRT_HORIZONTAL_SYNC_WIDTH_MASK) | > - ((pModeParam->horizontal_sync_start - 1) & > - CRT_HORIZONTAL_SYNC_START_MASK)); > + ((pModeParam->horizontal_sync_width << > + CRT_HORIZONTAL_SYNC_WIDTH_SHIFT) & > + CRT_HORIZONTAL_SYNC_WIDTH_MASK) | > + ((pModeParam->horizontal_sync_start - 1) & > + CRT_HORIZONTAL_SYNC_START_MASK)); > > poke32(CRT_VERTICAL_TOTAL, > - (((pModeParam->vertical_total - 1) << > - CRT_VERTICAL_TOTAL_TOTAL_SHIFT) & > - CRT_VERTICAL_TOTAL_TOTAL_MASK) | > - ((pModeParam->vertical_display_end - 1) & > - CRT_VERTICAL_TOTAL_DISPLAY_END_MASK)); > + (((pModeParam->vertical_total - 1) << > + CRT_VERTICAL_TOTAL_TOTAL_SHIFT) & > + CRT_VERTICAL_TOTAL_TOTAL_MASK) | > + ((pModeParam->vertical_display_end - 1) & > + CRT_VERTICAL_TOTAL_DISPLAY_END_MASK)); > > poke32(CRT_VERTICAL_SYNC, > - ((pModeParam->vertical_sync_height << > - CRT_VERTICAL_SYNC_HEIGHT_SHIFT) & > - CRT_VERTICAL_SYNC_HEIGHT_MASK) | > - ((pModeParam->vertical_sync_start - 1) & > - CRT_VERTICAL_SYNC_START_MASK)); > + ((pModeParam->vertical_sync_height << > + CRT_VERTICAL_SYNC_HEIGHT_SHIFT) & > + CRT_VERTICAL_SYNC_HEIGHT_MASK) | > + ((pModeParam->vertical_sync_start - 1) & > + CRT_VERTICAL_SYNC_START_MASK)); > > tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; > if (pModeParam->vertical_sync_polarity) > @@ -140,25 +139,25 @@ static int programModeRegisters(mode_parameter_t *pModeParam, > poke32(PANEL_HORIZONTAL_TOTAL, reg); > > poke32(PANEL_HORIZONTAL_SYNC, > - ((pModeParam->horizontal_sync_width << > - PANEL_HORIZONTAL_SYNC_WIDTH_SHIFT) & > - PANEL_HORIZONTAL_SYNC_WIDTH_MASK) | > - ((pModeParam->horizontal_sync_start - 1) & > - PANEL_HORIZONTAL_SYNC_START_MASK)); > + ((pModeParam->horizontal_sync_width << > + PANEL_HORIZONTAL_SYNC_WIDTH_SHIFT) & > + PANEL_HORIZONTAL_SYNC_WIDTH_MASK) | > + ((pModeParam->horizontal_sync_start - 1) & > + PANEL_HORIZONTAL_SYNC_START_MASK)); > > poke32(PANEL_VERTICAL_TOTAL, > - (((pModeParam->vertical_total - 1) << > - PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) & > - PANEL_VERTICAL_TOTAL_TOTAL_MASK) | > - ((pModeParam->vertical_display_end - 1) & > - PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK)); > + (((pModeParam->vertical_total - 1) << > + PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) & > + PANEL_VERTICAL_TOTAL_TOTAL_MASK) | > + ((pModeParam->vertical_display_end - 1) & > + PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK)); > > poke32(PANEL_VERTICAL_SYNC, > - ((pModeParam->vertical_sync_height << > - PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) & > - PANEL_VERTICAL_SYNC_HEIGHT_MASK) | > - ((pModeParam->vertical_sync_start - 1) & > - PANEL_VERTICAL_SYNC_START_MASK)); > + ((pModeParam->vertical_sync_height << > + PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) & > + PANEL_VERTICAL_SYNC_HEIGHT_MASK) | > + ((pModeParam->vertical_sync_start - 1) & > + PANEL_VERTICAL_SYNC_START_MASK)); > > tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; > if (pModeParam->vertical_sync_polarity) > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170313204853.24675-4-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >