From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751983AbdCSLD7 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 19 Mar 2017 07:03:59 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:33681 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751949AbdCSLD6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 19 Mar 2017 07:03:58 -0400
Date: Sun, 19 Mar 2017 12:03:54 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org, arnd@arndb.de,
        y2038@lists.linaro.org
Subject: Re: [RESEND PATCH 3/7] Change k_clock clock_get() to use
 timespec64
In-Reply-To: <1489900666-32268-4-git-send-email-deepa.kernel@gmail.com>
Message-ID: <alpine.DEB.2.20.1703191159550.3781@nanos>
References: <1489900666-32268-1-git-send-email-deepa.kernel@gmail.com> <1489900666-32268-4-git-send-email-deepa.kernel@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 18 Mar 2017, Deepa Dinamani wrote:
> -	int (*clock_get) (const clockid_t which_clock, struct timespec * tp);
> +	int (*clock_get) (const clockid_t which_clock, struct timespec64 * tp);

If you change things, then please fixup the white space noise as well '*tp'
is the proper syntax.

> @@ -1033,12 +1033,14 @@ SYSCALL_DEFINE2(clock_gettime, const clockid_t, which_clock,
>  {
>  	struct k_clock *kc = clockid_to_kclock(which_clock);
>  	struct timespec kernel_tp;
> +	struct timespec64 kernel_tp64;

Ordering please

Other than the nitpicks, this looks good.