From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751834AbdCSMPI (ORCPT ); Sun, 19 Mar 2017 08:15:08 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:22981 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbdCSMPE (ORCPT ); Sun, 19 Mar 2017 08:15:04 -0400 X-IronPort-AV: E=Sophos;i="5.36,188,1486422000"; d="scan'208";a="265179415" Date: Sun, 19 Mar 2017 13:13:59 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: w.d.hubbs@gmail.com, chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] [PATCH 1/2] staging: speakup: Moved AND operator to previous line. In-Reply-To: <20170319072403.10354-2-arushisinghal19971997@gmail.com> Message-ID: References: <20170319072403.10354-1-arushisinghal19971997@gmail.com> <20170319072403.10354-2-arushisinghal19971997@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 19 Mar 2017, Arushi Singhal wrote: > Moved logical AND operator to previous line to fix the following > checkpatch issue: You seem to have AND and OR confused. AND is &&, OR is ||. This patch is about OR, not AND. julia > > CHECK: Logical continuations should be on the previous line. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index c10445624e92..def1a36da9dd 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -2173,10 +2173,10 @@ speakup_key(struct vc_data *vc, int shift_state, int keycode, u_short keysym, > if (up_flag || spk_killed || type == KT_SHIFT) > goto out; > spk_shut_up &= 0xfe; > - kh = (value == KVAL(K_DOWN)) > - || (value == KVAL(K_UP)) > - || (value == KVAL(K_LEFT)) > - || (value == KVAL(K_RIGHT)); > + kh = (value == KVAL(K_DOWN)) || > + (value == KVAL(K_UP)) || > + (value == KVAL(K_LEFT)) || > + (value == KVAL(K_RIGHT)); > if ((cursor_track != read_all_mode) || !kh) > if (!spk_no_intr) > spk_do_flush(); > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170319072403.10354-2-arushisinghal19971997%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >