From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759744AbdCVNYh (ORCPT ); Wed, 22 Mar 2017 09:24:37 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:24071 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758734AbdCVNY3 (ORCPT ); Wed, 22 Mar 2017 09:24:29 -0400 X-IronPort-AV: E=Sophos;i="5.36,205,1486422000"; d="scan'208";a="217628110" Date: Wed, 22 Mar 2017 14:24:07 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v2] staging: rts5208: Replace a bit shift by a use of BIT. In-Reply-To: <20170322131757.GA5335@arushi-HP-Pavilion-Notebook> Message-ID: References: <20170322131757.GA5335@arushi-HP-Pavilion-Notebook> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with coccinelle: > @@ > constant c; > @@ > > -1 << c > +BIT(c) > > Signed-off-by: Arushi Singhal Acked-by: Julia Lawall > --- > changes in v2 > - remove the unnecessary parenthesis. > > drivers/staging/rts5208/rtsx_chip.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c > index 3511157a2c78..7f4107bffe31 100644 > --- a/drivers/staging/rts5208/rtsx_chip.c > +++ b/drivers/staging/rts5208/rtsx_chip.c > @@ -1490,7 +1490,7 @@ int rtsx_write_register(struct rtsx_chip *chip, u16 addr, u8 mask, u8 data) > > for (i = 0; i < MAX_RW_REG_CNT; i++) { > val = rtsx_readl(chip, RTSX_HAIMR); > - if ((val & (1 << 31)) == 0) { > + if ((val & BIT(31)) == 0) { > if (data != (u8)val) { > rtsx_trace(chip); > return STATUS_FAIL; > @@ -1518,7 +1518,7 @@ int rtsx_read_register(struct rtsx_chip *chip, u16 addr, u8 *data) > > for (i = 0; i < MAX_RW_REG_CNT; i++) { > val = rtsx_readl(chip, RTSX_HAIMR); > - if ((val & (1 << 31)) == 0) > + if ((val & BIT(31)) == 0) > break; > } > > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170322131757.GA5335%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >