From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935088AbdCWNt5 (ORCPT ); Thu, 23 Mar 2017 09:49:57 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48580 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755775AbdCWNt4 (ORCPT ); Thu, 23 Mar 2017 09:49:56 -0400 X-IronPort-AV: E=Sophos;i="5.36,210,1486422000"; d="scan'208";a="217777229" Date: Thu, 23 Mar 2017 14:49:44 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Arushi Singhal cc: Chris Brannon , Kirk Reiser , Samuel Thibault , Greg Kroah-Hartman , speakup@linux-speakup.org, driverdevel , LKML , outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1561654908-1490276985=:3193" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1561654908-1490276985=:3193 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT It should be staging: speakup:, not staging:speakup: On Thu, 23 Mar 2017, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". It would really be better to say what the patch does, not just say what error message you have fixed. julia > Signed-off-by: Arushi Singhal > --- > changes in v2 >  - change the commit message. > >  drivers/staging/speakup/speakup_apollo.c | 2 +- >  drivers/staging/speakup/speakup_decext.c | 4 ++-- >  2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/speakup_apollo.c > b/drivers/staging/speakup/speakup_apollo.c > index 9cfdbbfb9742..6ad83dc642c4 100644 > --- a/drivers/staging/speakup/speakup_apollo.c > +++ b/drivers/staging/speakup/speakup_apollo.c > @@ -173,7 +173,7 @@ static void do_catch_up(struct spk_synth *synth) >                 if (!synth->io_ops->synth_out(synth, ch)) { >                         outb(UART_MCR_DTR, speakup_info.port_tts + > UART_MCR); >                         outb(UART_MCR_DTR | UART_MCR_RTS, > -                                       speakup_info.port_tts + UART_MCR); > +                            speakup_info.port_tts + UART_MCR); >                         schedule_timeout(msecs_to_jiffies(full_time_val)); >                         continue; >                 } > diff --git a/drivers/staging/speakup/speakup_decext.c > b/drivers/staging/speakup/speakup_decext.c > index 929a28d618dc..c564bf8e1531 100644 > --- a/drivers/staging/speakup/speakup_decext.c > +++ b/drivers/staging/speakup/speakup_decext.c > @@ -206,11 +206,11 @@ static void do_catch_up(struct spk_synth *synth) >                                 if (!in_escape) >                                         synth->io_ops->synth_out(synth, > PROCSPEECH); >                                 spin_lock_irqsave(&speakup_info.spinlock, > -                                                       flags); > +                                                 flags); >                                 jiffy_delta_val = jiffy_delta->u.n.value; >                                 delay_time_val = delay_time->u.n.value; >                                 > spin_unlock_irqrestore(&speakup_info.spinlock, > -                                                       flags); > +                                                      flags); >                                 schedule_timeout(msecs_to_jiffies >                                                  (delay_time_val)); >                                 jiff_max = jiffies + jiffy_delta_val; > -- > 2.11.0 > > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9fNHFEUopsZH5rf > iuha-Pv0WA%2B8oACvT_cNxwiSX-rjg%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. > > --8323329-1561654908-1490276985=:3193--