From: Julia Lawall <julia.lawall@lip6.fr>
To: Christopher Bostic <cbostic@linux.vnet.ibm.com>
Cc: joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
alistair@popple.id.au, benh@kernel.crashing.org,
"Edward A . James" <eajames@us.ibm.com>,
Jeremy Kerr <jk@ozlabs.org>,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
rostedt@goodmis.org, mingo@redhat.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kbuild-all@01.org
Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)
Date: Thu, 30 Mar 2017 23:39:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1703302337590.2105@hadrien> (raw)
Is master on line 514 allocated with kmalloc, or the devm call on line
522?
julia
---------- Forwarded message ----------
Date: Fri, 31 Mar 2017 00:15:09 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master
Hi Chris,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.11-rc4 next-20170330]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
>> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29
vim +514 drivers/fsi/fsi-master-gpio.c
f4bd3b6a Chris Bostic 2017-03-29 498 {
f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master);
f4bd3b6a Chris Bostic 2017-03-29 500
f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0)
f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV;
f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable)
f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1);
f4bd3b6a Chris Bostic 2017-03-29 505
f4bd3b6a Chris Bostic 2017-03-29 506 return 0;
f4bd3b6a Chris Bostic 2017-03-29 507 }
f4bd3b6a Chris Bostic 2017-03-29 508
f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev)
f4bd3b6a Chris Bostic 2017-03-29 510 {
f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio(
f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev));
f4bd3b6a Chris Bostic 2017-03-29 513
f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master);
f4bd3b6a Chris Bostic 2017-03-29 515 }
f4bd3b6a Chris Bostic 2017-03-29 516
f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev)
f4bd3b6a Chris Bostic 2017-03-29 518 {
f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master;
f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio;
f4bd3b6a Chris Bostic 2017-03-29 521
f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next reply other threads:[~2017-03-30 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 21:39 Julia Lawall [this message]
2017-04-04 19:10 ` Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703302337590.2105@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=cbostic@linux.vnet.ibm.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@us.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®