From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753296AbdDLHYE (ORCPT ); Wed, 12 Apr 2017 03:24:04 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:59377 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbdDLHYA (ORCPT ); Wed, 12 Apr 2017 03:24:00 -0400 Date: Wed, 12 Apr 2017 09:23:58 +0200 (CEST) From: Thomas Gleixner To: Matthias Kaehlcke cc: linux-kernel@vger.kernel.org, Grant Grundler , Greg Hackmann , Michael Davidson Subject: Re: [PATCH] kernel/irq: Limit validation of cpumask_var_t to CONFIG_CPUMASK_OFFSTACK=y In-Reply-To: <20170411235217.71604-1-mka@chromium.org> Message-ID: References: <20170411235217.71604-1-mka@chromium.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Matthias Kaehlcke wrote: > With CONFIG_CPUMASK_OFFSTACK=y cpumask_var_t is a struct cpumask > pointer, otherwise a struct cpumask array with a single element. > > irq_thread_check_affinity() validates the cpumask_var_t field in the > interrupt descriptor by checking if it is not NULL. This works for > both CONFIG_CPUMASK_OFFSTACK=y/n, however clang raises the following > warning with CONFIG_CPUMASK_OFFSTACK=n: > > kernel/irq/manage.c:839:28: error: address of array > 'desc->irq_common_data.affinity' will always evaluate to 'true' > [-Werror,-Wpointer-bool-conversion] > > To get rid of the warning only validate the cpumask_var_t field when > CONFIG_CPUMASK_OFFSTACK=y. This ifdeffery is horrible. Can you please create a helper inline cpumask_available() or something like that which hides this in a header file. The irq code is probably not the only place which does this. Thanks, tglx