From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757573AbdDRUvB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Apr 2017 16:51:01 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:53469 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757493AbdDRUu7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Apr 2017 16:50:59 -0400
Date: Tue, 18 Apr 2017 22:50:43 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: Steven Rostedt <rostedt@goodmis.org>, jbaron@akamai.com,
        mingo@kernel.org, bigeasy@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp()
In-Reply-To: <20170418202708.d5xn2l5gn3mktbe5@hirez.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1704182250180.8081@nanos>
References: <20170418103213.089888286@infradead.org> <20170418103422.636958338@infradead.org> <20170418130350.cwfij23vc4ybklkp@hirez.programming.kicks-ass.net> <20170418124629.13316f8d@gandalf.local.home>
 <20170418202708.d5xn2l5gn3mktbe5@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 18 Apr 2017, Peter Zijlstra wrote:
> On Tue, Apr 18, 2017 at 12:46:29PM -0400, Steven Rostedt wrote:
> > On Tue, 18 Apr 2017 15:03:50 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > +++ b/kernel/padata.c
> > > @@ -1008,11 +1008,10 @@ static struct padata_instance *padata_al
> > >   *                         parallel workers.
> > >   *
> > >   * @wq: workqueue to use for the allocated padata instance
> > > - *
> > > - * Must be called from a get_online_cpus() protected region
> > 
> > Find the comment redundant?
> 
> Once there's code that enforces it? Yes. Nobody reads comments
> ;-)

Nobody enables lockdep either .....