From: Thomas Gleixner <tglx@linutronix.de>
To: Myungho Jung <mhjungk@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] timer: fix timer_migration to accept only 0 and 1
Date: Thu, 20 Apr 2017 14:53:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1704201449310.2059@nanos> (raw)
In-Reply-To: <1492640690-3550-1-git-send-email-mhjungk@gmail.com>
On Wed, 19 Apr 2017, Myungho Jung wrote:
> Error is not shown by setting invalid value to timer_migration. Valid
> values for timer_migration should be restricted to 0 and 1. Testcase for
> this bug is ltp/runpwtests06.
While I agree with the change, I disagree with the changelog. Where is the bug?
The timer code checks for timer_migration != 0 resp. == 0. So as long as
the value is != 0 it's enabled, if it's 0 it is disabled.
It's a correctness issue that we treat a sysctl which is basically a
boolean as such. Ideally we'd have: proc_doboolvec() for such cases and
convert all similar sysctls over to that.
Thanks,
tglx
next prev parent reply other threads:[~2017-04-20 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 22:24 Myungho Jung
2017-04-20 12:53 ` Thomas Gleixner [this message]
2017-04-20 17:36 ` Myungho Jung
2017-04-20 17:45 ` Thomas Gleixner
2017-04-20 18:08 ` Myungho Jung
2017-04-20 13:14 ` [tip:timers/core] timer/sysclt: Restrict timer migration sysctl values to " tip-bot for Myungho Jung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1704201449310.2059@nanos \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mhjungk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®