mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix NR_IRQS printk()
Date: Tue, 9 May 2017 09:08:05 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1705090903430.1798@nanos> (raw)
In-Reply-To: <1493805791-1357-1-git-send-email-vincent.legoll@gmail.com>

On Wed, 3 May 2017, Vincent Legoll wrote:

> Subject : [PATCH] Fix NR_IRQS printk()

The subject line is missing a subsystem token. Please consult

  Documentation/process/submitting-patches.rst

and run 'git log path/to/affected.file' to see how a proper subject line
should look like.

> - Missing some whitespace
> - Tell that the third number is "initcnt" (whatever that is)

Your changelog is telling WHAT the patch is doing, but not WHY and despite
the subject claiming to fix something the changelog lacks any information
about the problem it "fixes".

Aside of that: "(whatever that is)" is not really convincing that you know
what you are doing.

Thanks,

	tglx

  reply	other threads:[~2017-05-09  7:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 10:03 Vincent Legoll
2017-05-09  7:08 ` Thomas Gleixner [this message]
2017-05-09  7:41   ` Vincent Legoll
2017-05-09  8:20     ` [PATCH] genirq: Tell that early_irq_init() is printing the nr of preallocated irqs Vincent Legoll
2017-05-09  8:34       ` Vincent Legoll
2017-05-26 12:58         ` [tip:irq/core] genirq: Make early_irq_init() print out more informative tip-bot for Vincent Legoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1705090903430.1798@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®