From: Thomas Gleixner <tglx@linutronix.de>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: "'peterz@infradead.org'" <peterz@infradead.org>,
"'mingo@redhat.com'" <mingo@redhat.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'bp@alien8.de'" <bp@alien8.de>,
"'acme@kernel.org'" <acme@kernel.org>,
"'eranian@google.com'" <eranian@google.com>,
"'jolsa@kernel.org'" <jolsa@kernel.org>,
"'ak@linux.intel.com'" <ak@linux.intel.com>
Subject: RE: [PATCH V5] perf/x86: add sysfs entry to freeze counter on SMI
Date: Wed, 10 May 2017 15:56:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1705101551260.1979@nanos> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077536EB588@SHSMSX103.ccr.corp.intel.com>
On Mon, 8 May 2017, Liang, Kan wrote:
> Hi tglx,
>
> Are you OK with patch?
> Could I get your "acked-by"?
No.
> > > +static void flip_smm_bit(void *data)
> > > +{
> > > + bool set = *(int *)data;
data points to an unsigned long. So while this works on LE machines this is
still crap.
> > > + if (set) {
> > > + msr_set_bit(MSR_IA32_DEBUGCTLMSR,
> > > + DEBUGCTLMSR_FREEZE_IN_SMM_BIT);
> > > + } else {
> > > + msr_clear_bit(MSR_IA32_DEBUGCTLMSR,
> > > + DEBUGCTLMSR_FREEZE_IN_SMM_BIT);
> > > + }
I probably forgot, but why do we need an open coded version of __flip_bit()
instead of reusing that?
Thanks,
tglx
next prev parent reply other threads:[~2017-05-10 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 14:01 kan.liang
2017-04-18 14:21 ` Liang, Kan
2017-05-08 13:35 ` Liang, Kan
2017-05-10 13:56 ` Thomas Gleixner [this message]
2017-05-10 15:48 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1705101551260.1979@nanos \
--to=tglx@linutronix.de \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®