From: Thomas Gleixner <tglx@linutronix.de>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux@armlinux.org.uk, Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: handle_bad_irq and locking
Date: Fri, 12 May 2017 10:40:53 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1705121038420.1800@nanos> (raw)
In-Reply-To: <CADtm3G4LRyojo+kX=neOsVYVX9_aY66yj-9XuFrjvrQcZJJYxg@mail.gmail.com>
On Thu, 11 May 2017, Gregory Fong wrote:
> Hi Thomas,
>
> I noticed that when you changed arm irq handling to use the generic
> implementation back in 2006 that you changed do_bad_IRQ() to the
> following:
>
> +#define do_bad_IRQ(irq,desc,regs) \
> +do { \
> + spin_lock(&desc->lock); \
> + handle_bad_irq(irq, desc, regs); \
> + spin_unlock(&desc->lock); \
> +} while(0)
>
> and it's mostly stayed the same since then. As such, there are a few
> examples of this being open-coded in the kernel in various irqchip
> handlers such as that of drivers/irqchip/irq-brcmstb-l2.c, and even
> more cases where the lock isn't being grabbed before calling
> handle_bad_irq().
>
> Since handle_bad_irq() is sort of a flow handler like
> handle_edge_irq() etc., do you think it would make sense to do the
> same as those and have it do the locking on its own? A quick look
> through existing users of handle_bad_irq() at [1] suggests that either
> the locking isn't necessary or it's almost always done wrong.
Right. So the proper solution to this is to create a generic function
handle_bad_irq_desc()
have proper locking in it and move all users (including do_bad_IRQ()) over
to it.
Thanks,
tglx
next prev parent reply other threads:[~2017-05-12 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 23:21 Gregory Fong
2017-05-12 8:40 ` Thomas Gleixner [this message]
2017-05-15 8:46 ` Gregory Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1705121038420.1800@nanos \
--to=tglx@linutronix.de \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®