From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934755AbdEOPge (ORCPT <rfc822;w@1wt.eu>);
        Mon, 15 May 2017 11:36:34 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:34990 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933636AbdEOPgc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 May 2017 11:36:32 -0400
Date: Mon, 15 May 2017 17:36:29 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
cc: LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [patch 18/18] sched: Enable smp_processor_id() checks early
In-Reply-To: <20170515111257.0a9b1c46@gandalf.local.home>
Message-ID: <alpine.DEB.2.20.1705151734320.2027@nanos>
References: <20170514182716.347236777@linutronix.de> <20170514183613.926588875@linutronix.de> <20170515111257.0a9b1c46@gandalf.local.home>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 15 May 2017, Steven Rostedt wrote:

> On Sun, 14 May 2017 20:27:34 +0200
> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > smp_processor_id() checks are enabled after the boot process is done. That
> > hides bugs in the smp bringup and driver initialization code.
> > 
> > Enable it right before the first non-boot CPU is brought up.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> >  init/main.c            |    3 +++
> >  lib/smp_processor_id.c |    2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > 
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> >  init/main.c            |    3 +++
> >  lib/smp_processor_id.c |    2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -1025,6 +1025,9 @@ static noinline void __init kernel_init_
> >  	 */
> >  	set_cpus_allowed_ptr(current, cpumask_of(raw_smp_processor_id()));
> >  
> > +	/* Enable smp_processor_id() checks */
> > +	system_state = SYSTEM_BOOTING_SMP;
> > +
> 
> Just a nit, but why set this here and not just before
> smp_prepare_cpus()? Anyway...

Because smp_prepare_cpus() is full of "UP" assumptions. Thinking more about
it, we just can set the cpus allowed ptr right after creating it and just
have a single state which enables both checks. I'll have a look.

Thanks,

	tglx