From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752319AbdEVGUt (ORCPT ); Mon, 22 May 2017 02:20:49 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:10715 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbdEVGUs (ORCPT ); Mon, 22 May 2017 02:20:48 -0400 X-IronPort-AV: E=Sophos;i="5.38,377,1491256800"; d="scan'208";a="224409059" Date: Mon, 22 May 2017 08:20:45 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Bhumika Goyal cc: Takashi Iwai , alsa-devel@alsa-project.org, perex@perex.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures In-Reply-To: Message-ID: References: <1495021136-6999-1-git-send-email-bhumirks@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2017, Bhumika Goyal wrote: > On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai wrote: > > On Wed, 17 May 2017 14:33:45 +0200, > > Bhumika Goyal wrote: > >> > >> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai wrote: > >> > On Wed, 17 May 2017 13:38:56 +0200, > >> > Bhumika Goyal wrote: > >> >> > >> >> Declare snd_kcontrol_new structures as const as they are only passed an > >> >> argument to the function snd_ctl_new1. This argument is of type const, > >> >> so snd_kcontrol_new structures having this property can be made const. > >> >> Done using Coccinelle: > >> >> > >> >> @r disable optional_qualifier@ > >> >> identifier x; > >> >> position p; > >> >> @@ > >> >> static struct snd_kcontrol_new x@p={...}; > >> >> > >> >> @ok@ > >> >> identifier r.x; > >> >> position p; > >> >> @@ > >> >> snd_ctl_new1(&x@p,...) > >> >> > >> >> @bad@ > >> >> position p != {r.p,ok.p}; > >> >> identifier r.x; > >> >> @@ > >> >> x@p > >> >> > >> >> @depends on !bad disable optional_qualifier@ > >> >> identifier r.x; > >> >> @@ > >> >> +const > >> >> struct snd_kcontrol_new x; > >> >> > >> >> Signed-off-by: Bhumika Goyal > >> > > >> > As I already asked, could you send as a patchset if you have multiple > >> > similar patches? > >> > > >> > >> Sure. Will combine the already sent ones and some new ones into a > >> patchset and send again. > > > > Well, since there haven't been new submissions and the patches are > > trivial, I applied the existing four patches. If you have newer ones, > > please submit as a patchset. > > > > > > Hey, > > Thanks for applying the patches. > I have a doubt that since some of my coming patches are for the sound > subsystem containing similar changes and you will be applying those, > so can I combine and put all the changes in a single patch or sending > a patchset would be a correct way. I think he means that when you have more sound patches, just do them all at once. julia