From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966966AbdEXIEp (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 04:04:45 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:57723 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965834AbdEXIEf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 04:04:35 -0400
Date: Wed, 24 May 2017 10:04:20 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: kernel test robot <xiaolong.ye@intel.com>,
        Ingo Molnar <mingo@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        tipbuild@zytor.com, lkp@01.org
Subject: Re: [lkp-robot] [sched/core] 1c3c5eab17:
 BUG:using_smp_processor_id()in_preemptible
In-Reply-To: <20170524065202.v25vyu7pvba5mhpd@hirez.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1705241003590.2201@nanos>
References: <20170524052545.GQ1795@yexl-desktop> <20170524065202.v25vyu7pvba5mhpd@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 24 May 2017, Peter Zijlstra wrote:
> Subject: sched/clock: Fix early boot preempt warning
> 
> The more strict early boot preemption warnings found that
> __set_sched_clock_stable() was incorrectly assuming we'd still be
> running on a single CPU.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

> ---
>  kernel/sched/clock.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c
> index 1a0d389d2f2b..ca0f8fc945c6 100644
> --- a/kernel/sched/clock.c
> +++ b/kernel/sched/clock.c
> @@ -133,12 +133,19 @@ static void __scd_stamp(struct sched_clock_data *scd)
>  
>  static void __set_sched_clock_stable(void)
>  {
> -	struct sched_clock_data *scd = this_scd();
> +	struct sched_clock_data *scd;
>  
>  	/*
> +	 * Since we're still unstable and the tick is already running, we have
> +	 * to disable IRQs in order to get a consistent scd->tick* reading.
> +	 */
> +	local_irq_disable();
> +	scd = this_scd();
> +	/*
>  	 * Attempt to make the (initial) unstable->stable transition continuous.
>  	 */
>  	__sched_clock_offset = (scd->tick_gtod + __gtod_offset) - (scd->tick_raw);
> +	local_irq_enable();
>  
>  	printk(KERN_INFO "sched_clock: Marking stable (%lld, %lld)->(%lld, %lld)\n",
>  			scd->tick_gtod, __gtod_offset,
>