From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940815AbdEZNUb (ORCPT ); Fri, 26 May 2017 09:20:31 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:41291 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933335AbdEZNUa (ORCPT ); Fri, 26 May 2017 09:20:30 -0400 Date: Fri, 26 May 2017 15:20:27 +0200 (CEST) From: Thomas Gleixner To: Jeffy Chen cc: linux-kernel@vger.kernel.org, briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org Subject: Re: [PATCH] genirq: Check irq disabled & masked states in irq_shutdown In-Reply-To: <1495804658-12410-1-git-send-email-jeffy.chen@rock-chips.com> Message-ID: References: <1495804658-12410-1-git-send-email-jeffy.chen@rock-chips.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 May 2017, Jeffy Chen wrote: > If irq is already disabled and masked, we would hit a unbalanced irq > shutdown/disable/mask when freeing it. Errr? What exactly is unbalanced? None of the called functions has any counter or whatever. Can you please explain what you are trying to fix? Thanks, tglx