From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035327AbdEZObu (ORCPT ); Fri, 26 May 2017 10:31:50 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:47662 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755965AbdEZObs (ORCPT ); Fri, 26 May 2017 10:31:48 -0400 X-IronPort-AV: E=Sophos;i="5.38,397,1491256800"; d="scan'208";a="225473246" Date: Fri, 26 May 2017 16:31:42 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Bogdan Purcareata cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: Re: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver (fwd) Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The u32 values on lines 73 and 79 will not be less than 0. julia ---------- Forwarded message ---------- Date: Fri, 26 May 2017 19:31:28 +0800 From: kbuild test robot To: kbuild@01.org Cc: Julia Lawall Subject: Re: [PATCH v3 1/2] net: phy: Add Cortina CS4340 driver CC: kbuild-all@01.org In-Reply-To: <1495785519-1468-2-git-send-email-bogdan.purcareata@nxp.com> TO: Bogdan Purcareata CC: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org CC: Hi Bogdan, [auto build test WARNING on net-next/master] [also build test WARNING on v4.12-rc2 next-20170526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Bogdan-Purcareata/net-phy-Add-Cortina-CS4340-driver/20170526-170949 :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago >> drivers/net/phy/cortina.c:73:5-11: WARNING: Unsigned expression compared with zero: id_lsb < 0 >> drivers/net/phy/cortina.c:79:5-11: WARNING: Unsigned expression compared with zero: id_msb < 0 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 84281ef4be227acc6a2f638da7a6842f7f55348d vim +73 drivers/net/phy/cortina.c 84281ef4 Bogdan Purcareata 2017-05-26 67 static int cortina_probe(struct phy_device *phydev) 84281ef4 Bogdan Purcareata 2017-05-26 68 { 84281ef4 Bogdan Purcareata 2017-05-26 69 u32 phy_id = 0, id_lsb, id_msb; 84281ef4 Bogdan Purcareata 2017-05-26 70 84281ef4 Bogdan Purcareata 2017-05-26 71 /* Read device id from phy registers. */ 84281ef4 Bogdan Purcareata 2017-05-26 72 id_lsb = cortina_read_reg(phydev, VILLA_GLOBAL_CHIP_ID_LSB); 84281ef4 Bogdan Purcareata 2017-05-26 @73 if (id_lsb < 0) 84281ef4 Bogdan Purcareata 2017-05-26 74 return -ENXIO; 84281ef4 Bogdan Purcareata 2017-05-26 75 84281ef4 Bogdan Purcareata 2017-05-26 76 phy_id = id_lsb << 16; 84281ef4 Bogdan Purcareata 2017-05-26 77 84281ef4 Bogdan Purcareata 2017-05-26 78 id_msb = cortina_read_reg(phydev, VILLA_GLOBAL_CHIP_ID_MSB); 84281ef4 Bogdan Purcareata 2017-05-26 @79 if (id_msb < 0) 84281ef4 Bogdan Purcareata 2017-05-26 80 return -ENXIO; 84281ef4 Bogdan Purcareata 2017-05-26 81 84281ef4 Bogdan Purcareata 2017-05-26 82 phy_id |= id_msb; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation