From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751364AbdE3I4r (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 04:56:47 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:41567 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751192AbdE3I4q (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 04:56:46 -0400
X-IronPort-AV: E=Sophos;i="5.38,418,1491256800"; 
   d="scan'208";a="276511292"
Date: Tue, 30 May 2017 10:56:39 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Takashi Iwai <tiwai@suse.de>
cc: Bhumika Goyal <bhumirks@gmail.com>, alsa-devel@alsa-project.org,
        lgirdwood@gmail.com, broonie@kernel.org, clemens@ladisch.de,
        julia.lawall@lip6.fr, linuxppc-dev@lists.ozlabs.org, perex@perex.cz,
        johannes@sipsolutions.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: declare snd_kcontrol_new structures as const
In-Reply-To: <s5hvaoiencx.wl-tiwai@suse.de>
Message-ID: <alpine.DEB.2.20.1705301056200.2981@hadrien>
References: <1495896375-30855-1-git-send-email-bhumirks@gmail.com> <s5hvaoiencx.wl-tiwai@suse.de>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tue, 30 May 2017, Takashi Iwai wrote:

> On Sat, 27 May 2017 16:46:15 +0200,
> Bhumika Goyal wrote:
> >
> > Declare snd_kcontrol_new structures as const as they are only passed an
> > argument to the function snd_ctl_new1. This argument is of type const,
> > so snd_kcontrol_new structures having this property can be made const.
> > Done using Coccinelle:
> >
> > @r disable optional_qualifier@
> > identifier x;
> > position p;
> > @@
> > static struct snd_kcontrol_new x@p={...};
> >
> > @ok@
> > identifier r.x;
> > position p;
> > @@
> > snd_ctl_new1(&x@p,...)
> >
> > @bad@
> > position p != {r.p,ok.p};
> > identifier r.x;
> > @@
> > x@p
> >
> > @depends on !bad disable optional_qualifier@
> > identifier r.x;
> > @@
> > +const
> > struct snd_kcontrol_new x;
> >
> > Cross compiled these files:
> > sound/aoa/codecs/tas.c - powerpc
> > sound/mips/{hal2.c/sgio2audio.c} - mips
> > sound/ppc/{awacs.c/beep.c/tumbler.c} - powerpc
> > sound/soc/sh/siu_dai.c - sh
> > Could not find an architecture to compile sound/sh/aica.c.
> >
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>
> Applied now, as it looks safe enough.  But I prefer splitting to
> individual patches, so please try to do that at the next time.

Individual patches in a series?

julia