From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751313AbdFFHns (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Jun 2017 03:43:48 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:55164 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751284AbdFFHnr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Jun 2017 03:43:47 -0400
Date: Tue, 6 Jun 2017 09:43:41 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Xishi Qiu <qiuxishi@huawei.com>
cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        fenghua.yu@intel.com, Peter Zijlstra <peterz@infradead.org>,
        John Stultz <john.stultz@linaro.org>
Subject: Re: [RFC] ubsan: signed integer overflow in setitimer()
In-Reply-To: <593646B5.6070406@huawei.com>
Message-ID: <alpine.DEB.2.20.1706060939480.1885@nanos>
References: <59300285.6090105@huawei.com> <alpine.DEB.2.20.1706041703500.2813@nanos> <593646B5.6070406@huawei.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 6 Jun 2017, Xishi Qiu wrote:
> On 2017/6/4 23:06, Thomas Gleixner wrote:
> > On Thu, 1 Jun 2017, Xishi Qiu wrote:
> > 
> > Cc'ed John Stultz
> > 
> >> Hi, this is the test case, and then I got ubsan error
> >> (signed integer overflow) report, so the root cause is from
> >> user or kernel? Shall we change something in timeval_valid()?
> >>
> >>
> >> struct itimerval new_value;
> >> int ret;
> >>
> >> new_value.it_interval.tv_sec = 140673496649799L;
> >> new_value.it_interval.tv_usec = 6;
> >> new_value.it_value.tv_sec = 140673496649807L;
> >> new_value.it_value.tv_usec = 5;
> >>
> >> ret = setitimer(ITIMER_VIRTUAL, &new_value, NULL);
> >>
> >>
> >> [  533.326588] ================================================================================
> >> [  533.335346] UBSAN: Undefined behaviour in ./include/linux/time.h:239:27
> >> [  533.342155] signed integer overflow:
> >> [  533.345837] 140673496649807 * 1000000000 cannot be represented in type 'long int'
> >> [  533.422181]  set_cpu_itimer+0x49c/0x540
> >> [  533.442127]  do_setitimer+0xe1/0x540
> > 
> > We need a similar clamping of the conversion as we have for
> > timespec/val_to_ktime(). I'll have a look in the next days unless John
> > beats me to it.
> > 
> 
> Hi Thomas, anything new?

Let me spell it out to you again. I wrote on Sunday late night:

    "I'll have a look in the next days ...."

Do you really think I need a reminder after 24 hours?

Thanks,

	tglx