From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751444AbdFFKaC (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Jun 2017 06:30:02 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:56393 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751384AbdFFKaB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 6 Jun 2017 06:30:01 -0400
Date: Tue, 6 Jun 2017 12:29:57 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Mason <slash.tmp@free.fr>
cc: Marc Zyngier <marc.zyngier@arm.com>,
        Jason Cooper <jason@lakedaemon.net>,
        Mark Rutland <mark.rutland@arm.com>, Arnd Bergmann <arnd@arndb.de>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: Design of interrupt controller driver
In-Reply-To: <e0380463-f13f-2ca2-b941-7a40b3b8fc36@free.fr>
Message-ID: <alpine.DEB.2.20.1706061228430.1885@nanos>
References: <8bce8bdd-5801-f0c3-ada3-e1c68acc8913@free.fr> <alpine.DEB.2.20.1706041551530.2813@nanos> <025780ef-06e6-1e85-58da-4ce8f6c93536@free.fr> <alpine.DEB.2.20.1706042208080.3517@nanos> <6e4da485-42cc-9b70-1b4a-9729f646e014@free.fr>
 <alpine.DEB.2.20.1706051007050.3517@nanos> <77a6e423-5c6a-9e5a-d679-c2576074fe6d@free.fr> <alpine.DEB.2.20.1706060922220.1885@nanos> <e0380463-f13f-2ca2-b941-7a40b3b8fc36@free.fr>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 6 Jun 2017, Mason wrote:
> On 06/06/2017 09:39, Thomas Gleixner wrote:
> What about disable_irq(virq);
> That function /is/ exported API, and eventually calls mask_irq.
> 
> disable_irq -> __disable_irq_nosync -> __disable_irq -> irq_disable -> mask_irq

What you can call from an ISR is disable_irq_nosync(). disable_irq() will
deadlock.

Thanks,

	tglx