From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752218AbdFUW2O (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Jun 2017 18:28:14 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:52397 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750981AbdFUW2M (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Jun 2017 18:28:12 -0400
Date: Thu, 22 Jun 2017 00:28:09 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@linux.intel.com>
cc: LKML <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>, x86@kernel.org,
        Peter Anvin <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [patch 0/7] x86/pci: Switch to lockless ECAM configuration
 mode
In-Reply-To: <20170613002536.GA21242@tassilo.jf.intel.com>
Message-ID: <alpine.DEB.2.20.1706220026450.2152@nanos>
References: <20170316215002.726697858@linutronix.de> <20170613002536.GA21242@tassilo.jf.intel.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Andi,

On Mon, 12 Jun 2017, Andi Kleen wrote:
> On Thu, Mar 16, 2017 at 10:50:02PM +0100, Thomas Gleixner wrote:
> > Andi reported that the Intel Uncore performance monitoring suffers from the
> > global pci_lock which protects the generic PCI config space accessors.
> > 
> > This lock can be removed on X86 because all architecture specific config
> > space accessors are either serialized by a seperate lock or can be
> > converted to have their own locking. The mmconfig based access (ECAM) does
> > not require serialization at the config read/write level because the access
> > is a simple byte/word/dword read from or write to the memory mapped
> > configuration space. In that case the lock does not provide any more
> > protection than the hardware provides already.
> > 
> > The series converts the CE4100 PCI low level accessors to use the x86
> > specific pci_config_lock and implements the switch over to lockless ECAM
> > configureation space accesors when the system is capable.
> 
> What's the status of this patch series? The lock contention
> problem is still there.

Just rechecked. It still applies and boots (patch 6/7) dropped.

If Bjorn has no objections I can route it through tip tomorrow.

Thanks,

	tglx