From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517AbdGCKjD (ORCPT ); Mon, 3 Jul 2017 06:39:03 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42843 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753449AbdGCKjC (ORCPT ); Mon, 3 Jul 2017 06:39:02 -0400 Date: Mon, 3 Jul 2017 12:38:41 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: peterz@infradead.org, acme@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/4] perf/x86: Fix data source decoding for Skylake In-Reply-To: <20170622000304.27918-3-andi@firstfloor.org> Message-ID: References: <20170622000304.27918-1-andi@firstfloor.org> <20170622000304.27918-3-andi@firstfloor.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jun 2017, Andi Kleen wrote: > I didn't add a generic flag for hops because it's not needed > for Skylake. When is that going to come? > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index b1c0b187acfe..7cfeb54e0b5a 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -931,14 +931,20 @@ union perf_mem_data_src { > mem_snoop:5, /* snoop mode */ > mem_lock:2, /* lock instr */ > mem_dtlb:7, /* tlb access */ > - mem_rsvd:31; > + mem_lvl_num:4, /* memory hierarchy level number */ > + mem_remote:1, /* remote */ > + mem_snoopx:2, /* snoop mode, ext */ Is that extending snoopx another time? The question really is, whether the 2 bits are going to be sufficient for a while or are we going to add snoopx2 in a few month from now. Thanks, tglx