From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <douly.fnst@cn.fujitsu.com>
Cc: Colin King <colin.king@canonical.com>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andrew Banman <abanman@hpe.com>,
Mike Travis <mike.travis@hpe.com>,
Dimitri Sivanich <sivanich@sgi.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/platform/uv/BAU: minor cleanup, make some local functions static
Date: Tue, 4 Jul 2017 09:19:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1707040918070.9000@nanos> (raw)
In-Reply-To: <86c2556c-cc0e-b221-b81e-4433b61f0f82@cn.fujitsu.com>
On Tue, 4 Jul 2017, Dou Liyang wrote:
> At 07/03/2017 10:22 PM, Colin King wrote:
> > -int normal_busy(struct bau_control *bcp)
> > +static int normal_busy(struct bau_control *bcp)
>
> In my opinion, there is no need to mark *normal_busy* static, remove it
> directly.
>
> the commit c5d35d399e68(x86/UV2: Work around BAU bug) add it to
> handle_uv2_busy(), but the handle_uv2_busy() is rewritten now. the
> normal_busy is unused, can be remove.
Correct.
> By the way, there are also an other function named
> uv_bau_message_interrupt() can be remove.
Not so much.
# git grep uv_bau_message_interrupt arch/x86/
arch/x86/entry/entry_64.S:apicinterrupt3 UV_BAU_MESSAGE uv_bau_message_intr1 uv_bau_message_interrupt
arch/x86/platform/uv/tlb_uv.c:void uv_bau_message_interrupt(struct pt_regs *regs)
Thanks,
tglx
next prev parent reply other threads:[~2017-07-04 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 14:22 Colin King
2017-07-04 3:49 ` Dou Liyang
2017-07-04 7:19 ` Thomas Gleixner [this message]
2017-07-04 7:29 ` Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707040918070.9000@nanos \
--to=tglx@linutronix.de \
--cc=abanman@hpe.com \
--cc=colin.king@canonical.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=mingo@redhat.com \
--cc=sivanich@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®