From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755933AbdGKRw3 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Jul 2017 13:52:29 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:45206 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754917AbdGKRw2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Jul 2017 13:52:28 -0400
Date: Tue, 11 Jul 2017 19:52:24 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
cc: Tony Lindgren <tony@atomide.com>,
        Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Pavel Machek <pavel@ucw.cz>, Linus Walleij <linus.walleij@linaro.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [GIT pull] irq updates for 4.13
In-Reply-To: <CA+55aFybh_GFN5UZ=tAN1EgTxE=JnofYM6ft3XG90+coxEdRtQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1707111951010.1799@nanos>
References: <alpine.DEB.2.20.1707091044210.2493@nanos> <20170710133505.eo6w73kq2327n34p@earth> <CA+55aFz5=ubNvhTUTzk3kFuLMFToP7xh7h8NDXDor9w+cjsCBA@mail.gmail.com> <alpine.DEB.2.20.1707110815440.1799@nanos> <alpine.DEB.2.20.1707110933590.1799@nanos>
 <20170711135131.GW3730@atomide.com> <alpine.DEB.2.20.1707111636180.1799@nanos> <CA+55aFwDgG6tZeqX7QPwxvwK8MMn_+RSkOgfG_jxzKkzySV6vw@mail.gmail.com> <alpine.DEB.2.20.1707111815280.1799@nanos>
 <CA+55aFybh_GFN5UZ=tAN1EgTxE=JnofYM6ft3XG90+coxEdRtQ@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 11 Jul 2017, Linus Torvalds wrote:
> On Tue, Jul 11, 2017 at 9:19 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > What I do not understand here is that we have already power management
> > around all of that.
> >
> >        irq_chip_pm_get(&desc->irq_data);
> >        ...
> >        chip_bus_lock(desc);
> >        ...
> >        chip_bus_unlock_sync(desc);
> >        ...
> >        irq_chip_pm_put(&desc->irq_data);
> >
> > So why is that not sufficient and needs extra magic in that GPIO driver?
> 
> Well, irq_chip_pm_get/put() isn't called just over the operation, it's
> called over the *whole* sequence of the irq being enabled at all.
> 
> So the different (right now) is that
> 
>  - chip_bus_lock/unlock_sync() is purely done around the actual
> operations to set up and tear down the irq data.
> 
>    So this just covers the very short setup/teardown.
> 
>  - irq_chip_pm_get/put() is called around the *whole* "irqs can be active" block
> 
>    This covers the whole lifetime of the irq, from setup to free.
> 
> Very different.
> 
> I'd really prefer my simple patch for now, leaving everything working
> the way it used to work. I *think* it's ok for RT too. Yes?

Not completely, because of the free path issues. See the other mail. Tony
confirmed that it works. I wait for Sebastian and queue it with a proper
changelog, ok?

Thanks,

	tglx