From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445AbdGQU6P (ORCPT ); Mon, 17 Jul 2017 16:58:15 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:33773 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdGQU6O (ORCPT ); Mon, 17 Jul 2017 16:58:14 -0400 Date: Mon, 17 Jul 2017 22:58:05 +0200 (CEST) From: Thomas Gleixner To: Doug Berger cc: Marc Zyngier , mans@mansr.com, Bartosz Golaszewski , Sebastian Frias , Boris Brezillon , open list Subject: Re: [PATCH 1/6] genirq: generic chip: add generic irq_mask_ack functions In-Reply-To: Message-ID: References: <20170707192016.13001-1-opendmb@gmail.com> <20170707192016.13001-2-opendmb@gmail.com> <1ccd2ce6-ac51-afed-f8be-f453f18b5464@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Jul 2017, Doug Berger wrote: > Seeing as Mans has acked the change to his driver should I submit a V2 > with just the function he and I are using and remove the other five > permutations, or are you willing to move forward with the patch as is? Please resubmit with the implementation which is actually used. We can add the others when the need arises. You might mention that in the changelog and the function comment, so people looking for a suitable alternative will get the proper hint. Thanks, tglx