From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbdGZOYf (ORCPT ); Wed, 26 Jul 2017 10:24:35 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49221 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbdGZOYb (ORCPT ); Wed, 26 Jul 2017 10:24:31 -0400 Date: Wed, 26 Jul 2017 16:24:25 +0200 (CEST) From: Thomas Gleixner To: Marc Zyngier cc: Masahiro Yamada , Jason Cooper , Linux Kernel Mailing List Subject: Re: [PATCH] irqchip: create a Kconfig menu for irqchip drivers In-Reply-To: <218865f9-ac06-ba47-287e-cff188957736@arm.com> Message-ID: References: <1501041791-10131-1-git-send-email-yamada.masahiro@socionext.com> <3d59b609-aeec-9177-8849-da1fbd386191@arm.com> <7595babf-8cc8-9191-cead-09fe955a42af@arm.com> <218865f9-ac06-ba47-287e-cff188957736@arm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Jul 2017, Marc Zyngier wrote: > On 26/07/17 14:14, Masahiro Yamada wrote: > > The irqchip maintainers applied drivers > > with user-configurable Kconfig entries. > > They are *not* user-selectable, since there is *NO* menu entry. *You* > are making them user-selectable, and I'm objecting to that. Masahiro is right. They are user selectable. Enable CONFIG_SOC_IMX51 and you'll get a prompt for TS-4800 IRQ controller in the middle of the 'Device Drivers' menu. Same for the other options, which have prompts. The irqchip Kconfig is included from drivers/Kconfig so there is menu context, just not a proper one. I agree that this is crap and these prompts should be removed and the irq thingy selected by the stuff which needs it. Thanks, tglx