From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752800AbdHNKJx (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Aug 2017 06:09:53 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:45365 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752722AbdHNKJl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Aug 2017 06:09:41 -0400
Date: Mon, 14 Aug 2017 12:09:33 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
cc: Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] genirq: remove redundant ->handle_irq assignment
In-Reply-To: <1502329914-27098-1-git-send-email-yamada.masahiro@socionext.com>
Message-ID: <alpine.DEB.2.20.1708141206090.1865@nanos>
References: <1502329914-27098-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Aug 2017, Masahiro Yamada wrote:

> This function has "desc->handle_irq = handle;" a few lines above.
> The second assignment is redundant.

It's not as redundant as you might think. You missed to read the comment
above that. See also commit 1e12c4a9393b7.

Thanks,

	tglx