From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752813AbdHNOsn (ORCPT <rfc822;w@1wt.eu>);
        Mon, 14 Aug 2017 10:48:43 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:47941 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752314AbdHNOsl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 14 Aug 2017 10:48:41 -0400
Date: Mon, 14 Aug 2017 16:48:33 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
cc: Linus Walleij <linus.walleij@linaro.org>,
        Marc Zyngier <marc.zyngier@arm.com>, Jonathan Corbet <corbet@lwn.net>,
        Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>, linux-kernel@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator
 framework
In-Reply-To: <CAMRc=Mdsc9W5VJStkhwiKyc4evEnw1j6D8D3FewmVvGaSV4keA@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1708141647390.1865@nanos>
References: <20170814112056.3751-1-brgl@bgdev.pl> <20170814112056.3751-2-brgl@bgdev.pl> <alpine.DEB.2.20.1708141505160.1865@nanos> <CAMRc=Mdsc9W5VJStkhwiKyc4evEnw1j6D8D3FewmVvGaSV4keA@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> 2017-08-14 15:06 GMT+02:00 Thomas Gleixner <tglx@linutronix.de>:
> > On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> >
> >> Implement a simple, irq_work-based framework for simulating
> >> interrupts. Currently the API exposes routines for initializing and
> >> deinitializing the simulator object, enqueueing the interrupts and
> >> retrieving the allocated interrupt numbers based on the offset of the
> >> dummy interrupt in the simulator struct.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >> ---
> >>  include/linux/irq_sim.h |  44 ++++++++++++++++++
> >>  init/Kconfig            |   4 ++
> >>  kernel/Makefile         |   1 +
> >>  kernel/irq_sim.c        | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Please move this to kernel/irq/ ... and the config option to kernel/irq/Kconfig.
> >
> > Thanks,
> >
> >         tglx
> >
> >
> 
> How about moving irq_work.c there too?

We could, but irq_work is not really part of the interrupt subsystem, while
your interrupt simulator definitely is.

Thanks,

	tglx