From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752328AbdHOMvM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Aug 2017 08:51:12 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:52787 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751196AbdHOMvK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Aug 2017 08:51:10 -0400
Date: Tue, 15 Aug 2017 14:50:42 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Prarit Bhargava <prarit@redhat.com>
cc: linux-kernel@vger.kernel.org, Mark Salyzyn <salyzyn@android.com>,
        Jonathan Corbet <corbet@lwn.net>, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        John Stultz <john.stultz@linaro.org>,
        Stephen Boyd <sboyd@codeaurora.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Christoffer Dall <cdall@linaro.org>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        Ingo Molnar <mingo@kernel.org>, Joel Fernandes <joelaf@google.com>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Olof Johansson <olof@lixom.net>, Josh Poimboeuf <jpoimboe@redhat.com>,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH v5] printk: Add monotonic, boottime, and realtime
 timestamps
In-Reply-To: <1502398622-17435-1-git-send-email-prarit@redhat.com>
Message-ID: <alpine.DEB.2.20.1708151445000.1886@nanos>
References: <1502398622-17435-1-git-send-email-prarit@redhat.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Aug 2017, Prarit Bhargava wrote:
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index cedafa008de5..1ddf04201047 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -25,6 +25,7 @@
>  #include <linux/stop_machine.h>
>  #include <linux/pvclock_gtod.h>
>  #include <linux/compiler.h>
> +#include <linux/sched/clock.h>

That's needed because?

>  #include "tick-internal.h"
>  #include "ntp_internal.h"
> @@ -60,8 +61,39 @@ struct tk_fast {
>  	struct tk_read_base	base[2];
>  };
>  
> -static struct tk_fast tk_fast_mono ____cacheline_aligned;
> -static struct tk_fast tk_fast_raw  ____cacheline_aligned;
> +/* Suspend-time cycles value for halted fast timekeeper. */
> +static u64 cycles_at_suspend;
> +
> +static u64 dummy_clock_read(struct clocksource *cs)
> +{
> +	return cycles_at_suspend;
> +}
> +
> +static struct clocksource dummy_clock = {
> +	.read = dummy_clock_read,
> +};
> +
> +static struct tk_fast tk_fast_mono ____cacheline_aligned = {
> +	.base = {
> +		(struct tk_read_base){

Eew.

> +			.clock = &dummy_clock,
> +		},

	.base[0] = {
		.clock = &dummy_clock,
	},

	.base[1] = {
		.clock = &dummy_clock,
	},

Hmm?

> -static struct clocksource dummy_clock = {
> -	.read = dummy_clock_read,
> -};
> -

Can we please have that timekeeping change as a seperate patch?

Thanks,

	tglx