From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751389AbdHONsi (ORCPT <rfc822;w@1wt.eu>);
        Tue, 15 Aug 2017 09:48:38 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:53321 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750827AbdHONsh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 15 Aug 2017 09:48:37 -0400
Date: Tue, 15 Aug 2017 15:48:18 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
cc: Ingo Molnar <mingo@kernel.org>, Willy Tarreau <w@1wt.eu>,
        "Theodore Ts'o" <tytso@mit.edu>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        x86-ml <x86@kernel.org>, "Jason A. Donenfeld" <Jason@zx2c4.com>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Nicholas Mc Guire <der.herr@hofr.at>
Subject: Re: early x86 unseeded randomness
In-Reply-To: <20170815134514.r6qjotjgfmurwh64@pd.tnic>
Message-ID: <alpine.DEB.2.20.1708151546380.1886@nanos>
References: <20170814173515.n3vcpz37xh33ayuq@pd.tnic> <CA+55aFzhFABbj2XdTt8sL7h=pZqQn7Tf1_fJyVQcE5kpuLAfNg@mail.gmail.com> <20170814180048.m3igiaiunlyb5wur@pd.tnic> <CA+55aFzzNrsTiL67cS_ZsqZNLf3w0dqmrNbw5yXpT6BPm3zMYw@mail.gmail.com> <20170814190013.zixopgjyq26ukxcj@pd.tnic>
 <20170815013124.2afytkibspxrikdn@thunk.org> <20170815064437.GA1986@1wt.eu> <20170815074254.6byayhspc5tdtjb5@gmail.com> <alpine.DEB.2.20.1708151001290.1886@nanos> <20170815134514.r6qjotjgfmurwh64@pd.tnic>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 15 Aug 2017, Borislav Petkov wrote:
> On Tue, Aug 15, 2017 at 12:47:36PM +0200, Thomas Gleixner wrote:
> > 8<-------------------
> > 
> > --- a/arch/x86/kernel/tsc.c
> > +++ b/arch/x86/kernel/tsc.c
> > @@ -1360,3 +1360,19 @@ unsigned long calibrate_delay_is_known(v
> >  	return 0;
> >  }
> >  #endif
> > +
> > +u64 __init tsc_early_random(void)
> > +{
> > +	u64 uninitialized_var(res);
> > +	int i;
> > +
> > +	if (!boot_cpu_has(X86_FEATURE_TSC))
> > +		return res;
> > +
> > +	res ^= rdtsc();
> > +	for (i = 0; i < BITS_PER_LONG; i++) {
> > +		res ^= ((rdtsc() & 0x04) >> 2) << i;
> > +		udelay(2);
> > +	}
> > +	return res;
> > +}
> 
> Something like this is exactly what I was aiming at with my dumb patch.
> We could use this for early boot randomness on x86.
> 
> Should I turn it into proper patches or you want to?

Go ahead. What you actually want to do is to replace boot_cpu_has() with a
real cpuid() check because boot_cpu_has() is not initialized on real early
boot.

Thanks,

	tglx