mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: vikas.shivappa@intel.com, x86@kernel.org,
	linux-kernel@vger.kernel.org, hpa@zytor.com,
	peterz@infradead.org, ravi.v.shankar@intel.com,
	tony.luck@intel.com, fenghua.yu@intel.com, ak@linux.intel.com,
	eranian@google.com, davidcc@google.com
Subject: Re: [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu
Date: Wed, 16 Aug 2017 11:19:45 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1708161117450.1987@nanos> (raw)
In-Reply-To: <1502845243-20454-2-git-send-email-vikas.shivappa@linux.intel.com>

On Tue, 15 Aug 2017, Vikas Shivappa wrote:
> When a CPU is dying, we cancel the worker and schedule a new worker on a
> different CPU on the same domain. But if the timer is already about to
> expire (say 0.99s) then we essentially double the interval.
> 
> We modify the hot cpu handling to cancel the delayed work on the dying
> cpu and run the worker immediately on a different cpu in same domain. We
> donot flush the worker because the MBM overflow worker reschedules the
> worker on same CPU and scans the domain->cpu_mask to get the domain
> pointer.

You could alternatively use flush and make the worker code schedule the
work on a still online CPU in the domain instead of blindly rescheduling it
on the same CPU.

Thanks,

	tglx

  reply	other threads:[~2017-08-16  9:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16  1:00 [PATCH 0/2 V4] Cqm3 support based on resctrl along with MBM Vikas Shivappa
2017-08-16  1:00 ` [PATCH 1/2] x86/intel_rdt/mbm: Fix MBM overflow handler during hot cpu Vikas Shivappa
2017-08-16  9:19   ` Thomas Gleixner [this message]
2017-08-16 14:53     ` Luck, Tony
2017-08-16 14:57       ` Thomas Gleixner
2017-08-16 10:13   ` [tip:x86/cache] x86/intel_rdt/mbm: Fix MBM overflow handler during CPU hotplug tip-bot for Vikas Shivappa
2017-08-16  1:00 ` [PATCH 2/2] x86/intel_rdt/cqm: Improve limbo list processing Vikas Shivappa
2017-08-16 10:13   ` [tip:x86/cache] " tip-bot for Vikas Shivappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1708161117450.1987@nanos \
    --to=tglx@linutronix.de \
    --cc=ak@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.v.shankar@intel.com \
    --cc=tony.luck@intel.com \
    --cc=vikas.shivappa@intel.com \
    --cc=vikas.shivappa@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®