From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752085AbdHPOub (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 10:50:31 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:58634 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751943AbdHPOua (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 10:50:30 -0400
Date: Wed, 16 Aug 2017 16:50:28 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <marc.zyngier@arm.com>
cc: linux-kernel@vger.kernel.org
Subject: Re: [RCF PATCH] genirq/debugfs: Triggering of interrupts from
 userspace
In-Reply-To: <20170720155135.31962-1-marc.zyngier@arm.com>
Message-ID: <alpine.DEB.2.20.1708161645220.1987@nanos>
References: <20170720155135.31962-1-marc.zyngier@arm.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 20 Jul 2017, Marc Zyngier wrote:
> When developing new (and therefore buggy) interrupt related
> code, it can sometimes be useful to inject interrupts without
> having to rely on a device to actually generate them.
> 
> This functionnality relies on the irqchip driver to expose
> a irq_set_irqchip_state(IRQCHIP_STATE_PENDING) callback.

I like that, but can we please extend that to utilize the irq resend
mechanism:

	desc = ....;

	chip_bus_lock(desc);
        raw_spin_lock_irq(&desc->lock);

	if (has_set_state(desc))
		set_state(desc);
	else
		check_irq_resend(desc);

or something to that effect?

Thanks,

	tglx