From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbdHTQoN (ORCPT ); Sun, 20 Aug 2017 12:44:13 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:55468 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753101AbdHTQoM (ORCPT ); Sun, 20 Aug 2017 12:44:12 -0400 X-IronPort-AV: E=Sophos;i="5.41,404,1498514400"; d="scan'208";a="234865810" Date: Sun, 20 Aug 2017 18:44:10 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Dmitry Torokhov cc: Julia Lawall , Takashi Iwai , alsa-devel@alsa-project.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings In-Reply-To: <20170820162841.GA1176@dtor-ws> Message-ID: References: <20170820162841.GA1176@dtor-ws> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Aug 2017, Dmitry Torokhov wrote: > On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote: > > No need to set .owner here. The core will do it. > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button") > > Signed-off-by: Julia Lawall > > Signed-off-by: Fengguang Wu > > --- > > > > dc_ti_pwrbtn.c | 1 - > > Hm, this driver is neither in my tree nor in next; where is it coming > from? Sorry, it's a kbuild message and I seem to have deleted the message with that information... julia > > > 1 file changed, 1 deletion(-) > > > > --- a/drivers/input/keyboard/dc_ti_pwrbtn.c > > +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c > > @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla > > static struct platform_driver dc_ti_pwrbtn_driver = { > > .driver = { > > .name = DRIVER_NAME, > > - .owner = THIS_MODULE, > > }, > > .probe = dc_ti_pwrbtn_probe, > > }; > > -- > Dmitry >