From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755948AbdHYLIa (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Aug 2017 07:08:30 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:40944 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754727AbdHYLI2 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Aug 2017 07:08:28 -0400
Date: Fri, 25 Aug 2017 13:08:22 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
cc: Marc Zyngier <marc.zyngier@arm.com>,
        David Daney <david.daney@cavium.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] irqdomain: potential Oops in irq_domain_push_irq()
In-Reply-To: <20170825091000.z5taav6xj2yds6ch@mwanda>
Message-ID: <alpine.DEB.2.20.1708251306410.1883@nanos>
References: <20170825091000.z5taav6xj2yds6ch@mwanda>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 25 Aug 2017, Dan Carpenter wrote:

> This code generates a Smatch warning:
> 
>     kernel/irq/irqdomain.c:1511 irq_domain_push_irq()
>     warn: variable dereferenced before check 'root_irq_data' (see line 1508)
> 
> irq_get_irq_data() does sometimes return NULL pointers so it does look
> like this code could Oops.  I've moved the check for NULL earlier to
> fix this bug.

>>From Documentation/process/submitting-patches.rst:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

Is it that hard to read _and_ understand what those instructions mean?

Thanks,

	tglx