From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935405AbdHYWJ2 (ORCPT ); Fri, 25 Aug 2017 18:09:28 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:43153 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933269AbdHYWJ0 (ORCPT ); Fri, 25 Aug 2017 18:09:26 -0400 Date: Sat, 26 Aug 2017 00:09:18 +0200 (CEST) From: Thomas Gleixner To: Jan Beulich cc: mingo@elte.hu, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: use KERN_CONT in dump_pagetable() In-Reply-To: <599EB4FB02000078001730B8@prv-mh.provo.novell.com> Message-ID: References: <599EB4FB02000078001730B8@prv-mh.provo.novell.com> <599EB4FB02000078001730B8@prv-mh.provo.novell.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Aug 2017, Jan Beulich wrote: > The lack of newlines in preceding format strings is a clear indication > that these were meant to be continuations of one another, and indeed > output ends up quite a bit more compact (and readable) that way. > > Signed-off-by: Jan Beulich > --- > arch/x86/mm/fault.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > --- 4.13-rc6/arch/x86/mm/fault.c > +++ 4.13-rc6-x86-dumppgt-cont/arch/x86/mm/fault.c > @@ -415,9 +415,9 @@ static void dump_pagetable(unsigned long > goto out; > > pte = pte_offset_kernel(pmd, address); > - printk("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte)); > + printk(KERN_CONT "*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte)); Can you please make that pr_cont() while at it and change the pure printk()s in that function to pr_info()? Thanks, tglx