From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbdH1PPe (ORCPT ); Mon, 28 Aug 2017 11:15:34 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48591 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbdH1PPd (ORCPT ); Mon, 28 Aug 2017 11:15:33 -0400 Date: Mon, 28 Aug 2017 17:15:29 +0200 (CEST) From: Thomas Gleixner To: Pasha Tatashin cc: x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, hpa@zytor.com, douly.fnst@cn.fujitsu.com Subject: Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot In-Reply-To: <2d5087a2-2aca-aaba-4608-112facbd3208@oracle.com> Message-ID: References: <1503520884-99253-1-git-send-email-pasha.tatashin@oracle.com> <1503520884-99253-2-git-send-email-pasha.tatashin@oracle.com> <2d5087a2-2aca-aaba-4608-112facbd3208@oracle.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Aug 2017, Pasha Tatashin wrote: > > > +/* > > > + * Called once during to boot to initialize boot time. > > > + */ > > > +void read_boot_clock64(struct timespec64 *ts) > > > > And because its called only once, it does not need to be marked __init() > > and must be kept around forever, right? > > This is because every other architecture implements read_boot_clock64() > without __init: arm, s390. Beside, the original weak stub does not have __init > macro. So, I can certainly try to add it for x86, but I am not sure what is > the behavior once __init section is gone, but weak implementation stays. And what about fixing that everywhere? Just because something is wrong, it does not mean that it needs to be proliferated. Thanks, tglx