From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbdHaUNu (ORCPT ); Thu, 31 Aug 2017 16:13:50 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:34792 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbdHaUNt (ORCPT ); Thu, 31 Aug 2017 16:13:49 -0400 Date: Thu, 31 Aug 2017 22:13:46 +0200 (CEST) From: Thomas Gleixner To: Kees Cook cc: Christoph Hellwig , LKML Subject: Re: Converting struct timer_list callback argument to struct timer_list * In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Aug 2017, Kees Cook wrote: > Which gets me to here: > 747 files changed, 3363 insertions(+), 3410 deletions(-) > > And current builds with the forced casts removed show about 400 more > call sites to fix... That's a herculean task. Chapeau! > Does this look alright, Very well done. I like the temporary typecast trick. > and should some of this go into -next right > now, just to get some of the clean-ups into the tree? (Basically, > everything before "timer: Temporarily explicitly cast all callback > functions") Yes, just get that part in now. Thanks, tglx