From: Julia Lawall <julia.lawall@lip6.fr>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: gregkh@linuxfoundation.org, gilad@benyossef.com,
linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v4] Staging: ccree: ssi_cipher.c: Remove unused variable.
Date: Thu, 7 Sep 2017 08:54:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709070852150.3084@hadrien> (raw)
In-Reply-To: <1504735553-13753-1-git-send-email-srishtishar@gmail.com>
One last detail. The subject line above is not in the same format as that
of all of the other subject lines one commits affecting this file. You
can use git log --oneline to see what others have done. It is not really
possible to guess correctly. However, one does not generally include the
extension on a filename.
julia
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove local variable inflight_counter, as it is never used.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> Change in v4:
> -There is no longer a need to make the comment more comprehensible, as I
> have deleted the variable associated with it. The v3 of this patch was
> not based on the original patch, hence v4.
> drivers/staging/ccree/ssi_cipher.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..1ff3c8a 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
> void __iomem *cc_base)
> {
> int completion_error = 0;
> - u32 inflight_counter;
> struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>
> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>
> - /*Set the inflight couter value to local variable*/
> - inflight_counter = ctx_p->drvdata->inflight_counter;
> /*Decrease the inflight counter*/
> if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
> ctx_p->drvdata->inflight_counter--;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504735553-13753-1-git-send-email-srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-07 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 22:05 Srishti Sharma
2017-09-07 6:54 ` Julia Lawall [this message]
2017-09-07 7:12 ` [Outreachy kernel] " Srishti Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709070852150.3084@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=srishtishar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®