From: Julia Lawall <julia.lawall@lip6.fr>
To: Himanshi Jain <himshijain.hj@gmail.com>
Cc: outreachy-kernel@googlegroups.com, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH] Staging: iio: adc: Added Space around binary op.
Date: Fri, 8 Sep 2017 08:04:18 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709080802310.2161@hadrien> (raw)
In-Reply-To: <20170908044752.GA6199@himanshi-Inspiron-5558>
On Fri, 8 Sep 2017, Himanshi Jain wrote:
> Added space around(one on each side of) binary
I think that just around would be clear enough.
In the previous patches on this file, found with git log --oneline, a
subject line of staging: iio: ad7192: seems to be more popular when the
patch affects only this file. But maybe it doesn't matter either way.
julia
> operator(-) as preferred according to kernel
> coding style.
>
> Signed-off-by: Himanshi Jain <himshijain.hj@gmail.com>
> ---
> drivers/staging/iio/adc/ad7192.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index d11c6de..1aee662 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st,
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> - in_voltage-voltage_scale_available,
> + in_voltage - voltage_scale_available,
> 0444, ad7192_show_scale_available, NULL, 0);
>
> static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444,
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170908044752.GA6199%40himanshi-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-08 6:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 4:47 Himanshi Jain
2017-09-08 6:04 ` Julia Lawall [this message]
2017-09-08 6:29 ` Jonathan Cameron
2017-09-08 9:32 ` Jonathan Cameron
2017-09-08 9:37 ` Lars-Peter Clausen
2017-09-08 9:46 ` Jonathan Cameron
2017-09-08 9:59 ` [Outreachy kernel] " Julia Lawall
2017-09-08 10:11 ` Lars-Peter Clausen
2017-09-08 10:32 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709080802310.2161@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himshijain.hj@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome