From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: harsha <harshasharmaiitr@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v4] staging: pi433: Fixes minor typo errors
Date: Fri, 8 Sep 2017 11:56:01 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709081152520.3165@hadrien> (raw)
In-Reply-To: <20170908095039.ns6kjwa2j5jbrrbi@mwanda>
On Fri, 8 Sep 2017, Dan Carpenter wrote:
> On Fri, Sep 08, 2017 at 11:45:20AM +0200, Julia Lawall wrote:
> >
> >
> > On Fri, 8 Sep 2017, harsha wrote:
> >
> > > From: Harsha Sharma <harshasharmaiitr@gmail.com>
> > >
> > > Fixes checkpatch warning -- "occured" and "succesfully" are misspelled
> > >
> > > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> > > ---
> > > Changes in v4:
> > > -Correct the format of the subject.
> > > -Signed-off properly.
> >
> > It's not signed off properly. Like Greg just said (maybe the mails
> > crossed), the sign off needs to be the same as the From line. This
> > probably relates to your git configuration or your mailer. Send the patch
> > to yourself before sending it out on the mailing list to be sure that
> > everything is ok.
> >
>
> This is actually OK-ish... It's better when we don't have the extra
> From: and there is no need for that with gmail, but we sometimes allow
> it for companies which have broken mailservers.
Oops, I'm sorry. I didn't see the extra From line.
SubmittingPatches says that the From line should be provided:
The ``from`` line must be the very first line in the message body,
and has the form:
From: Original Author <author@example.com>
It does say:
If the ``from`` line is missing, then the ``From:`` line from the email
header will be used to determine the patch author in the changelog.
But it doesn't convey the same spirit as "we sometimes allow".
julia
>
> regards,
> dan carpenter
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170908095039.ns6kjwa2j5jbrrbi%40mwanda.
> For more options, visit https://groups.google.com/d/optout.
>
next prev parent reply other threads:[~2017-09-08 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 9:39 harsha
2017-09-08 9:45 ` [Outreachy kernel] " Julia Lawall
2017-09-08 9:50 ` Dan Carpenter
2017-09-08 9:56 ` Julia Lawall [this message]
2017-09-08 10:39 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709081152520.3165@hadrien \
--to=julia.lawall@lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®