From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751923AbdINLVt (ORCPT <rfc822;w@1wt.eu>);
        Thu, 14 Sep 2017 07:21:49 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:3395 "EHLO
        mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751602AbdINLVr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 14 Sep 2017 07:21:47 -0400
X-IronPort-AV: E=Sophos;i="5.42,392,1500933600"; 
   d="scan'208";a="237474238"
Date: Thu, 14 Sep 2017 13:21:13 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: =?ISO-8859-15?Q?J=E9r=E9my_Lefaure?= <jeremy.lefaure@lse.epita.fr>
cc: Michal Marek <mmarek@suse.com>, Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, cocci@systeme.lip6.fr,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Coccinelle: array_size: report even if include is
 missing
In-Reply-To: <20170914023807.12972-1-jeremy.lefaure@lse.epita.fr>
Message-ID: <alpine.DEB.2.20.1709141320170.3185@hadrien>
References: <20170914023807.12972-1-jeremy.lefaure@lse.epita.fr>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-728942300-1505388027=:3185"
Content-ID: <alpine.DEB.2.20.1709141320290.3185@hadrien>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--8323329-728942300-1505388027=:3185
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <alpine.DEB.2.20.1709141320291.3185@hadrien>



On Wed, 13 Sep 2017, Jérémy Lefaure wrote:

> Rule r does not depend on rule i (which is the include of
> linux/kernel.h) so the output should not depend on i in
> org and report mode.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

I guess that if the incude is missing, the person updating the code can
always add it.


> ---
>
> I have tested this patch in report mode on the file
> drivers/staging/rtlwifi/phydm/rtl8822b/halhwimg8822b_rf.c which does not
> use ARRAY_SIZE and does not include linux/kernel.h.
>
>  scripts/coccinelle/misc/array_size.cocci | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/array_size.cocci b/scripts/coccinelle/misc/array_size.cocci
> index 6ec05710b017..09520f0941f0 100644
> --- a/scripts/coccinelle/misc/array_size.cocci
> +++ b/scripts/coccinelle/misc/array_size.cocci
> @@ -72,13 +72,13 @@ position p;
>   (sizeof(E)@p /sizeof(T))
>  )
>
> -@script:python depends on i&&org@
> +@script:python depends on org@
>  p << r.p;
>  @@
>
>  coccilib.org.print_todo(p[0], "WARNING should use ARRAY_SIZE")
>
> -@script:python depends on i&&report@
> +@script:python depends on report@
>  p << r.p;
>  @@
>
> --
> 2.14.1
>
>
--8323329-728942300-1505388027=:3185--