From: Julia Lawall <julia.lawall@lip6.fr>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t
Date: Sat, 16 Sep 2017 19:19:56 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709161919380.1992@hadrien> (raw)
In-Reply-To: <a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar@gmail.com>
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Eliminate the fields that are not used and the comments
> associated with them.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> Changes in v2:
> - Use the word field instead of variable.
>
> drivers/staging/dgnc/dgnc_driver.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h
> index 5d2566e..082d659 100644
> --- a/drivers/staging/dgnc/dgnc_driver.h
> +++ b/drivers/staging/dgnc/dgnc_driver.h
> @@ -312,8 +312,6 @@ struct un_t {
> * @ch_err_overrun: Count of overruns on channel.
> * @ch_xon_sends: Count of xons transmitted.
> * @ch_xoff_sends: Count of xoffs transmitted.
> - * @proc_entry_pointer: Proc/<board>/<channel> entry.
> - * @dgnc_channel_table: Proc/<board>/<channel> entry.
> */
> struct channel_t {
> struct dgnc_board *ch_bd;
> @@ -382,10 +380,6 @@ struct channel_t {
>
> ulong ch_xon_sends;
> ulong ch_xoff_sends;
> -
> - struct proc_dir_entry *proc_entry_pointer;
> - struct dgnc_proc_entry *dgnc_channel_table;
> -
> };
>
> extern uint dgnc_major; /* Our driver/mgmt major */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a57f835fc443d51ae9eadd1b995435c215f14974.1505579409.git.srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
prev parent reply other threads:[~2017-09-16 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 16:38 [PATCH v2 0/2] Remove unused fields in structure definition Srishti Sharma
2017-09-16 16:38 ` [PATCH v2 1/2] Staging: dgnc: Remove unused fields in struct dgnc_board Srishti Sharma
2017-09-16 17:19 ` [Outreachy kernel] " Julia Lawall
2017-09-16 16:39 ` [PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t Srishti Sharma
2017-09-16 17:19 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709161919380.1992@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=srishtishar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®