From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937068AbdIZPgH (ORCPT ); Tue, 26 Sep 2017 11:36:07 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:49129 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934460AbdIZPgG (ORCPT ); Tue, 26 Sep 2017 11:36:06 -0400 Date: Tue, 26 Sep 2017 17:33:09 +0200 (CEST) From: Thomas Gleixner To: Prarit Bhargava cc: pmladek@suse.com, olof@lixom.net, akpm@linux-foundation.org, joelaf@google.com, rostedt@goodmis.org, corbet@lwn.net, jpoimboe@redhat.com, sergey.senozhatsky@gmail.com, Jason@zx2c4.com, geert+renesas@glider.be, gregkh@linuxfoundation.org, cdall@linaro.org, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, sboyd@codeaurora.org, mcgrof@kernel.org, paulmck@linux.vnet.ibm.com, npiggin@gmail.com, keescook@chromium.org, peterz@infradead.org, deepa.kernel@gmail.com, salyzyn@android.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:core/printk] printk: Add monotonic, boottime, and realtime timestamps In-Reply-To: <8e22fb69-05e5-af38-770d-1d4404b656b0@redhat.com> Message-ID: References: <6dfcd20a-d70a-d451-b332-9a0375543ea2@redhat.com> <8e22fb69-05e5-af38-770d-1d4404b656b0@redhat.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Sep 2017, Prarit Bhargava wrote: > On 09/26/2017 11:26 AM, Thomas Gleixner wrote: > > On Tue, 26 Sep 2017, Prarit Bhargava wrote: > > > >> On 09/26/2017 04:42 AM, tip-bot for Prarit Bhargava wrote: > >>> Commit-ID: 310b454a8653ea60d3eb21ce5ab03a282a32fbe1 > >>> Gitweb: http://git.kernel.org/tip/310b454a8653ea60d3eb21ce5ab03a282a32fbe1 > >>> Author: Prarit Bhargava > >>> AuthorDate: Mon, 18 Sep 2017 13:51:00 -0400 > >>> Committer: Thomas Gleixner > >>> CommitDate: Tue, 26 Sep 2017 10:38:07 +0200 > >>> > >>> printk: Add monotonic, boottime, and realtime timestamps > >>> > >>> printk.time=1/CONFIG_PRINTK_TIME=1 adds a unmodified local hardware clock > >>> timestamp to printk messages. The local hardware clock loses time each > >>> day making it difficult to determine exactly when an issue has occurred in > >>> the kernel log, and making it difficult to determine how kernel and > >>> hardware issues relate to each other. > >>> > >>> Make printk output different timestamps by adding options for no timestamp, > >>> the local hardware clock, monotonic clock, boottime clock, and clock > >>> realtime. The default clock can be selected via: > >>> > >>> - Kconfig > >>> - Kernel command line parameter > >>> - Sysfs file > >>> > >>> Note, that existing user space tools might be confused by selecting clock > >>> realtime, so handle with care. > >> > >> pmladek found a compile warning due to printk_time being unused. I will post a > >> v14 on LKML shortly. > > > > Errm. I applied v12. where the heck is v13? > > > > And in the applied patch printk_time is used..... > > Sorry, my mistake I meant v13. > > This morning pmladek posted about a warning when when CONFIG_PRINTK is not defined: > > https://marc.info/?l=linux-doc&m=150642667403344&w=2 > > I'm fixing it now for v13. Please send a delta patch.