From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbdJDNeM (ORCPT ); Wed, 4 Oct 2017 09:34:12 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:9443 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314AbdJDNeJ (ORCPT ); Wed, 4 Oct 2017 09:34:09 -0400 X-IronPort-AV: E=Sophos;i="5.42,477,1500933600"; d="scan'208";a="239723285" Date: Wed, 4 Oct 2017 15:34:05 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Srishti Sharma cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe In-Reply-To: <1507122755-5489-1-git-send-email-srishtishar@gmail.com> Message-ID: References: <1507122755-5489-1-git-send-email-srishtishar@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Again, you have three patches on different files with the same subject line. You could add the file name eg rtw_ap: to the subject line to make them unique. julia On Wed, 4 Oct 2017, Srishti Sharma wrote: > Use list_for_each_entry_safe to make the code more compact. Done > by the following semantic patch by coccinelle. > > @r@ > struct list_head* l; > expression e; > identifier m,list_del_init,f; > type T1; > T1* pos; > iterator name list_for_each_entry_safe; > @@ > > f(...){ > > +T1* tmp; > <+... > -while(...) > +list_for_each_entry_safe(pos,tmp,l,m) > { > ... > -pos = container_of(l,T1,m); > ... > -l=e; > <+... > list_del_init(&pos->m) > ...+> > } > ...+> > > } > > Signed-off-by: Srishti Sharma > --- > drivers/staging/rtl8188eu/core/rtw_ap.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c > index a2c599f..551af9e 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_ap.c > +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c > @@ -280,7 +280,7 @@ void expire_timeout_chk(struct adapter *padapter) > { > struct list_head *phead, *plist; > u8 updated = 0; > - struct sta_info *psta = NULL; > + struct sta_info *psta = NULL, *tmp; > struct sta_priv *pstapriv = &padapter->stapriv; > u8 chk_alive_num = 0; > char chk_alive_list[NUM_STA]; > @@ -292,10 +292,7 @@ void expire_timeout_chk(struct adapter *padapter) > plist = phead->next; > > /* check auth_queue */ > - while (phead != plist) { > - psta = container_of(plist, struct sta_info, auth_list); > - plist = plist->next; > - > + list_for_each_entry_safe(psta, tmp, plist, auth_list) { > if (psta->expire_to > 0) { > psta->expire_to--; > if (psta->expire_to == 0) { > @@ -326,10 +323,7 @@ void expire_timeout_chk(struct adapter *padapter) > plist = phead->next; > > /* check asoc_queue */ > - while (phead != plist) { > - psta = container_of(plist, struct sta_info, asoc_list); > - plist = plist->next; > - > + list_for_each_entry_safe(psta, tmp, plist, asoc_list) { > if (chk_sta_is_alive(psta) || !psta->expire_to) { > psta->expire_to = pstapriv->expire_to; > psta->keep_alive_trycnt = 0; > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1507122755-5489-1-git-send-email-srishtishar%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >