From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbdJDOlz (ORCPT ); Wed, 4 Oct 2017 10:41:55 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:29199 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752243AbdJDOly (ORCPT ); Wed, 4 Oct 2017 10:41:54 -0400 X-IronPort-AV: E=Sophos;i="5.42,477,1500933600"; d="scan'208";a="239734071" Date: Wed, 4 Oct 2017 16:41:50 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Dan Carpenter cc: Julia Lawall , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, Srishti Sharma , linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe In-Reply-To: <20171004144012.jciztelhwjdyzpwg@mwanda> Message-ID: References: <1507062512-9145-1-git-send-email-srishtishar@gmail.com> <20171004112103.cvu5ipkudfpz2adc@mwanda> <20171004144012.jciztelhwjdyzpwg@mwanda> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Oct 2017, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: > > > > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > > > > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: > > > > Use list_for_each_entry_safe when the list elements may get deleted > > > > during traversal. > > > > > > This patch is fine as a cleanup but none of these are actually buggy. > > > > I'm not sure what you are getting at with the comment. The commit doesn't > > say that they were buggy. Perhaps the commit message could have been more > > verbose, like "Use list operators on list_head values. > > List_for_each_entry_safe is needed because the list elements get deleted > ^^^^^^^^^ > > It is not *needed*, the original code works fine. The problem with the > original code, is that it's ugly as sin. > > > during the traversal"? > > The changelog needs to say *why* we're applying the patch. At first I > thought it was going to fix a use after free. What I would prefer in > the changelog is something like: "This patch is a cleanup and doesn't > change runtime behavior. It changes an open coded list traversal to > use list_for_each_entry_safe." OK, Srishti, you can put that. But change the subject lines too. julia > > regards, > dan carpenter > > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171004144012.jciztelhwjdyzpwg%40mwanda. > For more options, visit https://groups.google.com/d/optout. >