From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751413AbdJDRIB (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 13:08:01 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:36456 "EHLO
        mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751240AbdJDRIA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 13:08:00 -0400
X-IronPort-AV: E=Sophos;i="5.42,478,1500933600"; 
   d="scan'208";a="294292519"
Date: Wed, 4 Oct 2017 19:07:57 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Srishti Sharma <srishtishar@gmail.com>
cc: Dan Carpenter <dan.carpenter@oracle.com>, devel@driverdev.osuosl.org,
        Greg KH <gregkh@linuxfoundation.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>,
        outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use
 list_for_each_entry_safe
In-Reply-To: <CAB3L5owT483S1ytafbS1CVLS06069CtiB7LFcmQCTSOFMH3Exg@mail.gmail.com>
Message-ID: <alpine.DEB.2.20.1710041907100.2815@hadrien>
References: <1507122755-5489-1-git-send-email-srishtishar@gmail.com> <alpine.DEB.2.20.1710041533110.2815@hadrien> <20171004150813.kajdk27w4ngrz57w@mwanda> <CAB3L5owT483S1ytafbS1CVLS06069CtiB7LFcmQCTSOFMH3Exg@mail.gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Wed, 4 Oct 2017, Srishti Sharma wrote:

> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote:
> >> Again, you have three patches on different files with the same subject
> >> line.  You could add the file name eg rtw_ap: to the subject line to make
> >> them unique.
> >>
> >
> > And the subject needs to start with [PATCH v3] and then after the
> > Signed off by line put:
> Shouldn't it be only v2 as I haven't sent a v2 for this before.

It should be ok.  There was a v1 that only did list_entry and where all
the patches had the same subject, but Greg already dropped that one.

julia

>
> Regards,
> Srishti
> >
> > ---
> > v2 and v3: Changes to the subjects and changelogs.
> >
> > regards,
> > dan carpenter
>